Adjusted the automated node placement#52
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts automated node placement so that, when child node coordinates are not stored in the design file, the nodes are arranged on a circle accounting for the central availability node, and the default circle radius is derived from the minimum inter-area distance at the top level.
Changes:
- In
setup_topology.jl, attempt to loadx/yfor each child from the saved design file before falling back tolon/lat, and computeradius = min_dist / 3from those coordinates. - Subtract one from
nodes_countwhen placing nodes whose parent is aSystemGeo, to account for the centeredGeoAvailabilitynode. - Update
place_nodes_in_circledocstring parameter names and use explicitFloat32conversions in the angle computation.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/setup_topology.jl | Reorders initialization, adds design-file coordinate loading for SystemGeo, and adjusts nodes_count for the central availability node. |
| src/utils_gen/structures_utils.jl | Aligns docstring parameter names with the function signature and uses explicit Float32 in the angle computation. |
| NEWS.md | Adds an unversioned release note describing the placement adjustments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
dqpinel
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the following:
Area, they are now placed symetrically around the circle (that is, acounting for one node being theGeoAvailabilitynode to be placed at the center). This is illustrated well by comparing changes to thedocs/src/figures/EMI_geography_Oslo.pngfile.top_leveldesign file.