Skip to content

Fix: Ensure Rust toolchain is present for pre-commit-autoupdate workflow#1171

Merged
alexdewar merged 1 commit intomainfrom
fix-missing-rust-for-pre-commit-autoupdate-workflow
Mar 4, 2026
Merged

Fix: Ensure Rust toolchain is present for pre-commit-autoupdate workflow#1171
alexdewar merged 1 commit intomainfrom
fix-missing-rust-for-pre-commit-autoupdate-workflow

Conversation

@alexdewar
Copy link
Copy Markdown
Member

@alexdewar alexdewar commented Mar 4, 2026

Description

Apologies for all the pre-commit-related faffing... it seems the last fix wasn't actually sufficient. I've tested that the workflow runs in this branch now (minus actually getting it to open a PR), so hopefully this is the last one 😄.

It seems the pre-commit autoupdate Action also runs pre-commit after updating, so it needs a Rust toolchain for, e.g., the cargo fmt hook.

Fix by ensuring the Rust toolchain is present for this workflow.

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc
  • Update release notes for the latest release if this PR adds a new feature or fixes a bug
    present in the previous release

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.30%. Comparing base (04b86f7) to head (692a3f0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1171   +/-   ##
=======================================
  Coverage   87.30%   87.30%           
=======================================
  Files          57       57           
  Lines        7706     7706           
  Branches     7706     7706           
=======================================
  Hits         6728     6728           
  Misses        673      673           
  Partials      305      305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexdewar alexdewar force-pushed the fix-missing-rust-for-pre-commit-autoupdate-workflow branch from d685157 to 692a3f0 Compare March 4, 2026 14:19
@alexdewar alexdewar added the bug Something isn't working label Mar 4, 2026
@alexdewar alexdewar added this to MUSE Mar 4, 2026
@alexdewar alexdewar moved this to 👀 In review in MUSE Mar 4, 2026
@alexdewar alexdewar requested review from Aurashk and tsmbland March 4, 2026 14:21
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works it's fine with me!

@tsmbland tsmbland marked this pull request as ready for review March 4, 2026 14:33
Copilot AI review requested due to automatic review settings March 4, 2026 14:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures the scheduled pre-commit-autoupdate GitHub Actions workflow has a Rust toolchain available, since the autoupdate action runs pre-commit after updating hooks and some hooks require Rust tooling.

Changes:

  • Add actions-rust-lang/setup-rust-toolchain@v1 to the pre-commit-autoupdate workflow so Rust-dependent hooks can run during the post-update pre-commit execution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@alexdewar alexdewar merged commit 93cfd18 into main Mar 4, 2026
12 of 13 checks passed
@alexdewar alexdewar deleted the fix-missing-rust-for-pre-commit-autoupdate-workflow branch March 4, 2026 14:55
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in MUSE Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants