Temporarily disable broken markdownlint-cli hook#1179
Conversation
The `markdownlint-cli` hook is currently broken due to an upstream bug. Let's just disable it for now as it's causing CI failures. We can re-enable it later and re-run it over any markdown files we've changed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1179 +/- ##
=======================================
Coverage 87.30% 87.30%
=======================================
Files 57 57
Lines 7706 7706
Branches 7706 7706
=======================================
Hits 6728 6728
Misses 673 673
Partials 305 305 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Temporarily disables the markdownlint-cli pre-commit hook to avoid CI failures caused by an upstream markdownlint-cli issue.
Changes:
- Comments out the
markdownlint-clirepo +markdownlint-fixhook block in.pre-commit-config.yaml - Adds a note with a link to the upstream issue causing fresh-install breakage
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # - repo: https://github.com/igorshubovych/markdownlint-cli | ||
| # rev: v0.48.0 | ||
| # hooks: | ||
| # - id: markdownlint-fix |
There was a problem hiding this comment.
Commenting out the entire hook works, but it also removes the ability to run it intentionally (e.g., in a manual stage) and makes future re-enabling slightly more error-prone. Consider keeping the hook enabled but restricting it to stages: [manual] (or an equivalent non-default stage used in this repo) so contributors can still run it explicitly while CI/normal pre-commit stages remain unblocked.
| # - repo: https://github.com/igorshubovych/markdownlint-cli | |
| # rev: v0.48.0 | |
| # hooks: | |
| # - id: markdownlint-fix | |
| - repo: https://github.com/igorshubovych/markdownlint-cli | |
| rev: v0.48.0 | |
| hooks: | |
| - id: markdownlint-fix | |
| stages: [manual] |
tsmbland
left a comment
There was a problem hiding this comment.
Sure.
Is this an issue with all versions or just the latest version? (i.e. could we downgrade instead?)
|
I tried downgrading and it didn't work 😞. I think the issue is a transitive dep of |
Description
The
markdownlint-clihook is currently broken due to an upstream bug. Let's just disable it for now as it's causing CI failures. We can re-enable it later and re-run it over any markdown files we've changed.Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks