Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1195 +/- ##
=======================================
Coverage 87.32% 87.32%
=======================================
Files 57 57
Lines 7726 7726
Branches 7726 7726
=======================================
Hits 6747 6747
Misses 673 673
Partials 306 306 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a repository-level Python version pin to make uv/pre-commit setup reproducible across developer machines and avoid failures from using an older system Python.
Changes:
- Introduces a
.python-versionfile specifying Python3.12for tooling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
alexdewar
left a comment
There was a problem hiding this comment.
but perhaps better to pin the Python version using a
.python-versionfile, as described here. Unless there's some reason why we shouldn't pin the Python version?
No, I think this is a good idea!
In fact, maybe we should consider having a pyproject.toml file and pinning the versions of Python dependencies there, as well as the Python version. (I've just been adding dependencies to scripts directly like this so far.) I can imagine that a few of the docs-related scripts might just stop working in a few years, which will mean we have the annoyance of backporting patches in order to build old docs. What do you think?
Either way, this is an improvement, so I think we should merge and worry about that later.
Just had a go setting everything up on a new laptop, following the dev instruction. All super clear and everything worked really well with one exception, when I got to running pre-commit hooks with
just pre-commit:ERROR: Package 'check-jsonschema' requires a different Python: 3.9.6 not in '>=3.10'I was able to fix it by running
uv tool install --python 3.12 pre-commit --forcebut perhaps better to pin the Python version using a
.python-versionfile, as described here. Unless there's some reason why we shouldn't pin the Python version?