Move decision_lexico_tolerance parameter to agents table#460
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 95.53% 95.40% -0.14%
==========================================
Files 31 31
Lines 4571 4588 +17
Branches 4571 4588 +17
==========================================
+ Hits 4367 4377 +10
- Misses 101 106 +5
- Partials 103 105 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexdewar
approved these changes
Mar 19, 2025
Member
alexdewar
left a comment
There was a problem hiding this comment.
Spotted a few things that are mostly stylistic, but otherwise looks good! Definitely nicer having that value inside the enum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This moves the
decision_lexico_toleranceparameter from theagent_objectivestable over to theagentstable, as we want the parameter to be defined at the agent level rather than the objective level.I've incorporated the parameter into the
DecisionRuleenum as this applies specifically toDecisionRule::Lexicographical.Initially,
decision_ruleanddecision_lexico_toleranceare read in toAgentRawas aStringandOption<f64>, which are then parsed inread_agents_file_from_iterto create aDecisionRulewhich is stored inAgentDone my best at the error handling, but there are probably some improvements to be made here
Fixes #454
Type of change
Key checklist
$ cargo test$ cargo docFurther checks