Skip to content

Move constraints code to new submodule#470

Merged
tsmbland merged 1 commit intomainfrom
constraints_module
Apr 4, 2025
Merged

Move constraints code to new submodule#470
tsmbland merged 1 commit intomainfrom
constraints_module

Conversation

@tsmbland
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland commented Apr 4, 2025

Just figured optimisation.rs is a bit big and worth breaking it up a bit. Especially as we'll probably want to add more constraints in the future

@tsmbland tsmbland marked this pull request as ready for review April 4, 2025 09:47
@tsmbland tsmbland requested a review from alexdewar April 4, 2025 09:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 95.38462% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.10%. Comparing base (fc61563) to head (1b6ac70).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/simulation/optimisation/constraints.rs 95.38% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          34       35    +1     
  Lines        4947     4947           
  Branches     4947     4947           
=======================================
  Hits         4705     4705           
  Misses        120      120           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible 👍

@tsmbland tsmbland merged commit a9fe89a into main Apr 4, 2025
7 checks passed
@tsmbland tsmbland deleted the constraints_module branch April 4, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants