Skip to content

Macro for creating map structs#489

Closed
tsmbland wants to merge 0 commit intomainfrom
maps
Closed

Macro for creating map structs#489
tsmbland wants to merge 0 commit intomainfrom
maps

Conversation

@tsmbland
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland commented Apr 16, 2025

Description

Written a macro to create map structs, and applied this to DemandMap and CommodityCostMap

Planning to keep using this macro to implement all the necessary map structs, as discussed in #476, so it may be refined/improved further as I go along

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (043e63e) to head (dcdfdd9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files          36       36           
  Lines        4893     4893           
  Branches     4893     4893           
=======================================
  Hits         4650     4650           
  Misses        123      123           
  Partials      120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmbland tsmbland changed the base branch from main to remove_keys April 16, 2025 09:24
@tsmbland tsmbland changed the title Tidy Map structs Macro for creating map structs Apr 16, 2025
@tsmbland tsmbland marked this pull request as ready for review April 16, 2025 10:56
@tsmbland tsmbland requested a review from alexdewar April 16, 2025 10:56
@tsmbland
Copy link
Copy Markdown
Collaborator Author

I've made an alternative PR (#490) which is definitely simpler. Interested to hear thoughts on both

@tsmbland tsmbland marked this pull request as draft April 16, 2025 15:48
Base automatically changed from remove_keys to main April 23, 2025 07:49
@tsmbland tsmbland added this to MUSE Apr 23, 2025
@tsmbland tsmbland self-assigned this Apr 23, 2025
@alexdewar alexdewar mentioned this pull request Apr 23, 2025
10 tasks
@tsmbland
Copy link
Copy Markdown
Collaborator Author

Going with #490 instead

@tsmbland tsmbland closed this Apr 23, 2025
@github-project-automation github-project-automation Bot moved this to ✅ Done in MUSE Apr 23, 2025
@tsmbland tsmbland reopened this Apr 23, 2025
@tsmbland tsmbland closed this Apr 23, 2025
@tsmbland tsmbland deleted the maps branch April 23, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant