Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 85.39% 85.36% -0.03%
==========================================
Files 38 38
Lines 3410 3410
Branches 3410 3410
==========================================
- Hits 2912 2911 -1
- Misses 305 306 +1
Partials 193 193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
LGTM! Much easier to read.
Just FYI: I used the title and description fields because they're listed in the table schema specification: https://specs.frictionlessdata.io/table-schema/#title
They're both optional fields though, and the frictionless tool at least doesn't seem to object to the extra notes field in there. I was essentially using the title as a description anyway.
A couple of extra things I noticed that are actually my fault:
- The
demand.yamlschema has ayearsfield that should beyear. (You can validate withfrictionless validate --schema schemas/input/demand.yaml examples/simple/demand.csv) - The subheadings seem to be repeated over and over, e.g. there's a Commodities subheading above each of the sections for the commodity-related CSV files
You can fix them on this branch or I can do it later.
| @@ -26,10 +26,9 @@ This file contains information about the input file format for MUSE 2.0. | |||
| (such as a requirement that the value is >=0 etc.). -#} | |||
| {%- if file.notes %} | |||
| #### Notes | |||
There was a problem hiding this comment.
Let's leave a newline after the heading:
| #### Notes | |
| #### Notes | |
|
Thanks. All fixed now |
Description
A suggested change to the input data documentation to make it slightly easier to follow. This is sort of in between what we currently have and what we briefly had before:
Main changes:
Also added some suggested vscode extensions
Fixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docFurther checks