Skip to content

Bump version to v1.2.0rc2#451

Merged
tsmbland merged 2 commits intodevelopfrom
rc2
Aug 13, 2024
Merged

Bump version to v1.2.0rc2#451
tsmbland merged 2 commits intodevelopfrom
rc2

Conversation

@tsmbland
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland commented Aug 13, 2024

Because there are a few more recent changes that weren't incorporated into rc1

Ideally we'd also merge #450 before creating the release. This would just mean that I can modify the release guide to advise people to use the aggregate sink for sector outputs

@tsmbland tsmbland requested review from alexdewar and dalonsoa August 13, 2024 09:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.28%. Comparing base (0f1f518) to head (4246210).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #451   +/-   ##
========================================
  Coverage    71.28%   71.28%           
========================================
  Files           44       44           
  Lines         5885     5885           
  Branches      1154     1154           
========================================
  Hits          4195     4195           
  Misses        1369     1369           
  Partials       321      321           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmbland
Copy link
Copy Markdown
Collaborator Author

Also tempted to just make this v1.2.0, not bother with the whole release candidate thing, and just do more regular minor version updates. Thoughts? @alexdewar @dalonsoa

@alexdewar
Copy link
Copy Markdown
Member

Also tempted to just make this v1.2.0, not bother with the whole release candidate thing, and just do more regular minor version updates. Thoughts? @alexdewar @dalonsoa

I think it doesn't matter too much either way, provided you communicate with the users so that they don't get bitten by breaking changes. Either way though, it would be helpful if users could actually run the new code to check we haven't broken anything we don't know about. Making an RC release might be a good way of communicating this: you can tell them that they've got an opportunity to tell you about this before you make a proper release and break their models. Up to you though.

@tsmbland tsmbland merged commit 8efdb8e into develop Aug 13, 2024
@tsmbland tsmbland deleted the rc2 branch August 13, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants