Modernize remote configuration. #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
force-pushed
the
new-config
branch
from
750233c to
6d072c7
Compare
Switch from the deprecated rbe_autoconfig workspace rule to using bazel-toolchain's rbe_configs_gen. I.e., I ran: $ rbe_configs_gen --toolchain_container=gcr.io/bazel-public/ubuntu2004-java11@sha256:69a78f121230c6d5cbfe2f4af8ce65481aa3f2acaaaf8e899df335f1ac1b35b5 --exec_os=linux --target_os=linux --output_config_path remote_config --output_src_root . -generate_java_configs=false Really, the only thing this gives us is the cc toolchain configuration for the container image. But that is a substantial amount of crosstool goop. .bazelrc configuration is generally simpler now. We can also upgrade to Bazel 5. Fixes #18.
benjaminp
force-pushed
the
new-config
branch
from
6d072c7 to
327174a
Compare
ulfjack
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from the deprecated rbe_autoconfig workspace rule to using bazel-toolchain's rbe_configs_gen. I.e., I ran:
Really, the only thing this gives us is the cc toolchain configuration for the container image. But that is a substantial amount of crosstool goop.
.bazelrc configuration is generally simpler now. We can also upgrade to Bazel 5.
Fixes #18.