Support cross-compilation from macOS for C++ and Java in .bazelrc #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Awesome! I successfully built |
Contributor
laszlocsomor
left a comment
laszlocsomor
left a comment
There was a problem hiding this comment.
The BUILD files are formatted and also updated, which makes seeing the actual changes difficult.
Could you please create a commit that just formats the files, and rebase this commit on that, finally pushing the two to this PR's branch?
Contributor
Author
|
Sure, just sent #29. Will rebase this one afterward. |
Contributor
Thanks! |
- In .bazelrc:
- Add --cpu=k8. Without this, Bazel tries to select darwin_arm64 (or whatever
the native platform is). This is still needed because Bazel still doesn't
fully support platforms and toolchains for C++.
- Add comments explaining what's missing and what to change.
- Remove --tls_certificate. Bazel reports an error if it's used.
(Should engflow-ca.crt be removed, too?)
- In //remote_config/cc:
- Generalize armeabi_cc_toolchain_config to stub_cc_toolchain_config
and declare a stub for darwin_arm64. This shouldn't be needed in theory,
and C++ targets build without it, but Java targets need it. More stubs
may be needed for --cpu values on other platforms.
- Run buildifier on BUILD.
jayconrod
force-pushed
the
jayconrod-cross-cpp
branch
from
bf92f17 to
a95d5f0
Compare
Contributor
Author
|
Rebased. Should be ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the native platform is). This is still needed because Bazel still doesn't
fully support platforms and toolchains for C++.
(Should engflow-ca.crt be removed, too?)
and declare a stub for darwin_arm64. This shouldn't be needed in theory,
and C++ targets build without it, but Java targets need it. More stubs
may be needed for --cpu values on other platforms.