Skip to content

Conversation

@anfelbar
Copy link
Collaborator

@anfelbar anfelbar commented Aug 19, 2022

It includes a demo sever that receives the data from the client using grpc protocol.

@anfelbar anfelbar requested review from lfpino and ulfjack August 19, 2022 21:36
@anfelbar
Copy link
Collaborator Author

@ulfjack I have added a demo server that receives messages from the client. This is part of these tasks. The server and proto files are modifications of the ones provided by grpc hellloworldserver. I have added the header stating
the license. Can you show me the proper way to document the licenses?

@anfelbar
Copy link
Collaborator Author

anfelbar commented Aug 19, 2022

@Unnar This example will be helpful for airbnb. Can you please execute the client against the canary cluster (or your preferred one)? It would be cool if you could reproduce the executing by reading the documentation before we send it to airbnb next week. WDYT?

@anfelbar anfelbar requested a review from Unnar August 22, 2022 14:02
Copy link
Contributor

@Unnar Unnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Managed to reproduce against Canary cluster following the documentation (only tested running with certificates since that is what Canary supports and is the most common use case AFAIK)

@anfelbar
Copy link
Collaborator Author

LGTM! Managed to reproduce against Canary cluster following the documentation (only tested running with certificates since that is what Canary supports and is the most common use case AFAIK)

Exactly, we are able to run againts any cluster but we need certificates or tokens. Thanks for the testing!

@anfelbar anfelbar merged commit cfe1e54 into main Aug 24, 2022
@anfelbar anfelbar deleted the andres-notification-example branch August 24, 2022 22:55
@keepinflow
Copy link

this one is merged and publicly available. still, would you review the
java/com/engflow/notificationqueue/README.md @plaindocs . Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants