Skip to content

Conversation

@nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Nov 22, 2024

  • Creating PR to run Buck2 samples in CI
  • Uses github auth to authenticate buck2 client with EngFlow cluster - https://docs.engflow.com/re/config/options.html#experimental_github_auth_container
  • Uses latest version of Buck2, if we start having issues with this approach will migrate to use of dotslash for configs.
  • Runs the cpp, golang and python Buck2 samples, as more are added they need to be include in the test script
  • DONE: use pre-installed zstd once I release images with the package


# Run cpp example
cd buck2/cpp
../../buck2-exe build //:cpp_lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't you create an alias instead and use an absolute path? Something like alias buck2="$(realpath buck2-exe)" and then just invoke buck2 normally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@TheGrizzlyDev TheGrizzlyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

@@ -0,0 +1,23 @@
#!/usr/bin/env bash
set -xe
shopt -s expand_aliases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have also used a function FYI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will consider that option in the general case. In this case I think using a function might be too much, but if the script starts getting more complex as we add more samples I will switch to using a function.

@nlopezgi nlopezgi merged commit d6f3530 into main Dec 4, 2024
5 checks passed
@nlopezgi nlopezgi deleted the nlopezgi/buck2CI branch December 4, 2024 17:30
anfelbar added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants