-
Notifications
You must be signed in to change notification settings - Fork 13
Set up CI to run buck2 samples #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
infra/test-buck2.sh
Outdated
|
|
||
| # Run cpp example | ||
| cd buck2/cpp | ||
| ../../buck2-exe build //:cpp_lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't you create an alias instead and use an absolute path? Something like alias buck2="$(realpath buck2-exe)" and then just invoke buck2 normally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
| @@ -0,0 +1,23 @@ | |||
| #!/usr/bin/env bash | |||
| set -xe | |||
| shopt -s expand_aliases | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could have also used a function FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I will consider that option in the general case. In this case I think using a function might be too much, but if the script starts getting more complex as we add more samples I will switch to using a function.
Uh oh!
There was an error while loading. Please reload this page.