Skip to content

Added support for csharp and hello world example #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 23, 2022
Merged

Added support for csharp and hello world example #49

merged 7 commits into from
Nov 23, 2022

Conversation

@anfelbar
Copy link
Collaborator

@anfelbar anfelbar commented Nov 22, 2022 •
edited
Loading

About

Adding csharp support and hello world example.
Run with

Linux

bazel build --host_platform @io_bazel_rules_dotnet//dotnet/toolchain:linux_amd64_3.1.100 --platforms @io_bazel_rules_dotnet//dotnet/toolchain:linux_amd64_3.1.100 //csharp/...

MacOS

bazel build --host_platform @io_bazel_rules_dotnet//dotnet/toolchain:darwin_amd64_3.1.100 --platforms @io_bazel_rules_dotnet//dotnet/toolchain:darwin_amd64_3.1.100 //csharp/...

Progress #36

@anfelbar anfelbar mentioned this pull request Nov 22, 2022
Closed
8 tasks
jayconrod
jayconrod reviewed Nov 22, 2022
View reviewed changes
@anfelbar anfelbar requested a review from jayconrod November 22, 2022 23:04
jayconrod
jayconrod approved these changes Nov 23, 2022
View reviewed changes
.github/workflows/main.yml Outdated
- name: Building //csharp directory (Linux)
if: runner.os == 'Linux'
run: bazel build //csharp/... --config=linux
Copy link
Contributor

@jayconrod jayconrod Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need --config=linux or --config=macos here with the changes in .bazelrc. They should be enabled automatically.

Copy link
Collaborator Author

@anfelbar anfelbar Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there is no need for two different steps, correct?

Copy link
Contributor

@jayconrod jayconrod Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Both runners should be able to run the same command.

anfelbar and others added 2 commits November 23, 2022 17:40
@anfelbar @jayconrod
Update .bazelrc
3e7cf97 
Co-authored-by: Jay Conrod <jay@engflow.com>
@anfelbar
No need for two steps when building csharp
95a70bd
@anfelbar anfelbar merged commit ff8b908 into main Nov 23, 2022
@anfelbar anfelbar deleted the andres-csharp-example branch November 23, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayconrod jayconrod jayconrod approved these changes

@lfpino lfpino Awaiting requested review from lfpino

@Yannic Yannic Awaiting requested review from Yannic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anfelbar @jayconrod