Skip to content

Conversation

@afrueda97
Copy link
Contributor

Proposal for the Python example.

@afrueda97 afrueda97 linked an issue Dec 6, 2022 that may be closed by this pull request
@anfelbar
Copy link
Collaborator

anfelbar commented Dec 6, 2022

It looks good so far. Now please continue with the example until you can successfully execute bazel run //python:python. It should show hello world. We will continue working in this PR.

@afrueda97 afrueda97 requested review from sarahraza007 and removed request for saraadams December 6, 2022 18:43
@anfelbar anfelbar changed the title 56 python example Adding perl support and hello world example Dec 6, 2022
@anfelbar anfelbar changed the title Adding perl support and hello world example Adding python support and hello world example Dec 6, 2022
@afrueda97
Copy link
Contributor Author

Thanks Andrés,
Strange things happening with the editor, the files weren't empty locally.

Should be runnable now!

@anfelbar
Copy link
Collaborator

anfelbar commented Dec 6, 2022

Please add the directory to the CI workflow builds as the other languages do in .github/workflows/main.yml

@anfelbar
Copy link
Collaborator

anfelbar commented Dec 6, 2022

In your current branch please do:

git fetch
git merge origin/main

Then fix the conflicts, commit and push again to this branch.

Co-authored-by: Andrés Felipe Barco Santa <andres@engflow.com>
@anfelbar
Copy link
Collaborator

You should merge this.

@afrueda97 afrueda97 merged commit 8eecf17 into main Dec 13, 2022
@afrueda97 afrueda97 deleted the 56-python-example branch December 13, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python example

3 participants