Checkstyle#483
Merged
LadyCailin merged 7 commits intoEngineHub:masterfrom May 13, 2018
Merged
Conversation
Made Tab/whitespace usage consistent.
- Added maven's checkstyle plugin (applies to main and test .java files).
- Added a check for line length <= 120 (currently marked as ignored due to >7000 violations).
- Disallow whitespace indents (force TABs).
- Disallow star imports (import blabla.*).
- Disallow empty blocks ({}).
- Disallow trailing whitespaces/tabs.
- Replaced leading 4-wide whitespaces with tabs. - Removed/replaced remaining leading whitespaces to maintain consistency. - Added *'s to multiline docs where they were missing.
Removed trailing whitespaces and tabs.
Replaced star imports with the actually used imports.
- Removed EmptyBlock checkstyle check since it triggered for cases where it is not necessarily bad. - Removed several empty blocks where they were not necessary.
Disallow whitespaces after '(' anf before ')'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added maven's checkstyle plugin with a few basic rules and changed code to match these basic rules.
More checks/rules can be added to eventually get and even force consistent code, but as inconsistent as CH source files are currently, this will require quite some work.