fix: make projet able to have a working xmake repo

[Miou-zora]

Pull Request

Description

Related Issues (Optional, put "None" if there are no related issues)

Fixes #(issue)
Relates to #(issue)

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Performance improvement
• Code refactoring
• Build/CI configuration change
• Project related stuff

Changes Made

List of the main changes in this PR:

• Change 1
• Change 2
• Change 3

Testing (Optional, put "None" if you didn't have to test anything)

• Unit tests pass (xmake test)
• Code follows the project's style guidelines (clang-format)
• Manual testing performed (describe what you tested)

Test Environment

• OS: [e.g. Windows, Ubuntu, macOS]
• Compiler: [e.g. MSVC, GCC, Clang]

Documentation

• I have updated the relevant documentation
• I have added/updated comments in the code
• No documentation changes are required

Checklist (Don't delete any options)

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published

Time Spent (Optional, put "None" if you don't know)

Screenshots/Videos (Optional, put "None" if it's not relevant)

Breaking Changes (Optional, Put "None" if there are no breaking changes)

Additional Notes (Optional, Put "None" if there are no additional notes)

Summary by CodeRabbit

• Bug Fixes

  • Enhanced graphics surface configuration to gracefully handle scenarios where adapter resources are unavailable.

• Chores

  • Refactored plugin build system header file discovery to use automatic directory scanning instead of fixed patterns, improving maintainability.

[coderabbitai]

Warning

Review limit reached

@Miou-zora, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 51 minutes and 45 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4b273858-ce64-4070-a1fc-fbbcffa7b9b7

📥 Commits

Reviewing files that changed from the base of the PR and between a8285c4 and be89c39.

📒 Files selected for processing (1)

• src/plugin/graphic/src/system/initialization/ConfigureSurface.cpp

📝 Walkthrough

Walkthrough

Build system header inclusion patterns are modernized across multiple plugin targets to dynamically enumerate subdirectories instead of hardcoding header paths. Surface configuration adapter acquisition becomes conditional, allowing initialization without a required adapter resource.

Changes

Build system and runtime resource handling

Layer / File(s)	Summary
Build system header inclusion modernization src/engine/xmake.lua, src/plugin/camera-movement/xmake.lua, src/plugin/physics/xmake.lua	Engine target adds plugin .ipp header inclusion. Camera-movement and physics targets replace hardcoded header subdirectory paths with dynamic directory-walk logic using os.filedirs("src/*") to enumerate and include all immediate subdirectories' .hpp files.
Conditional adapter resource handling in surface configuration src/plugin/graphic/src/system/initialization/ConfigureSurface.cpp	Adapter resource acquisition is deferred and gated behind core.HasResource<Resource::Adapter>() check. Surface initialization proceeds without requiring adapter presence, and adapter-info setup is nested within the conditional availability block.

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

build, bug

🐰 Headers now hop through folders with grace,
Dynamic patterns fill the build-time space.
Adapters check before they claim their claim,
Surfaces configure without the strain!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title mentions fixing an xmake repository issue, which aligns with the primary changes involving xmake.lua build script updates across multiple plugin modules.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-xmake-repo

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (3)

src/plugin/camera-movement/xmake.lua (1)

44-48: ⚖️ Poor tradeoff

Consider extracting the header iteration pattern to reduce duplication.

This dynamic header inclusion loop is duplicated in src/plugin/physics/xmake.lua (lines 19-23). Consider extracting this pattern into a shared xmake helper function if this pattern will be used across multiple plugin build scripts.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/plugin/camera-movement/xmake.lua` around lines 44 - 48, Extract the
duplicated header-iteration loop into a shared xmake helper function (e.g.,
add_plugin_headers(root_dir) or add_headers_for_dir) placed in a common build
helper module and require it from plugin xmake.lua files; move the for _, file
in ipairs(os.filedirs("src/*")) ... add_headerfiles("src/(" ..
path.filename(file) .. "/**.hpp)") logic into that helper, then replace the loop
in src/plugin/camera-movement/xmake.lua and src/plugin/physics/xmake.lua with a
single call to the helper (passing "src" or the plugin subdir as needed) so both
scripts reuse the same implementation.

src/plugin/physics/xmake.lua (2)

19-23: ⚡ Quick win

Skip adding .ipp for physics plugin unless .ipp files are introduced
src/plugin/physics/xmake.lua currently only adds *.hpp under src/* subdirectories; there are no .ipp files present under src/plugin/physics/src/, so the extra .ipp inclusion isn’t needed right now. If .ipp files are added later, extend the glob accordingly.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/plugin/physics/xmake.lua` around lines 19 - 23, Currently the xmake
script loops over os.filedirs("src/*") and calls add_headerfiles with a glob
that only includes "*.hpp"; to follow the review, do not add "*.ipp" here—leave
add_headerfiles("src/(" .. path.filename(file) .. "/*.hpp)") as the header
inclusion and avoid adding any "*.ipp" pattern (only add .ipp later if .ipp
files are actually introduced); locate the loop using os.filedirs, os.isdir and
the add_headerfiles call in src/plugin/physics/xmake.lua and ensure no "*.ipp"
glob is added.

---

19-23: ⚡ Quick win

Physics header glob is sufficient for current layout; recursive glob is optional

src/plugin/physics/xmake.lua uses src/(<subdir>/*.hpp), and the current src/plugin/physics/src/* layout has no nested .hpp files beyond the immediate subdirectories—so it won’t miss headers today. Switching to /**.hpp would be a consistency/future-proofing improvement, not a correctness fix.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/plugin/physics/xmake.lua` around lines 19 - 23, Update the header glob to
be future-proof: in the loop that iterates src/* and calls
add_headerfiles("src/(" .. path.filename(file) .. "/*.hpp)"), change the pattern
to include recursive matches (e.g. use /**.hpp instead of /* .hpp) so
add_headerfiles uses "src/(" .. path.filename(file) .. "/**.hpp)"; keep the same
loop and path.filename usage but replace the glob to ensure nested headers are
picked up.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/plugin/camera-movement/xmake.lua`:
- Around line 44-48: Extract the duplicated header-iteration loop into a shared
xmake helper function (e.g., add_plugin_headers(root_dir) or
add_headers_for_dir) placed in a common build helper module and require it from
plugin xmake.lua files; move the for _, file in ipairs(os.filedirs("src/*")) ...
add_headerfiles("src/(" .. path.filename(file) .. "/**.hpp)") logic into that
helper, then replace the loop in src/plugin/camera-movement/xmake.lua and
src/plugin/physics/xmake.lua with a single call to the helper (passing "src" or
the plugin subdir as needed) so both scripts reuse the same implementation.

In `@src/plugin/physics/xmake.lua`:
- Around line 19-23: Currently the xmake script loops over os.filedirs("src/*")
and calls add_headerfiles with a glob that only includes "*.hpp"; to follow the
review, do not add "*.ipp" here—leave add_headerfiles("src/(" ..
path.filename(file) .. "/*.hpp)") as the header inclusion and avoid adding any
"*.ipp" pattern (only add .ipp later if .ipp files are actually introduced);
locate the loop using os.filedirs, os.isdir and the add_headerfiles call in
src/plugin/physics/xmake.lua and ensure no "*.ipp" glob is added.
- Around line 19-23: Update the header glob to be future-proof: in the loop that
iterates src/* and calls add_headerfiles("src/(" .. path.filename(file) ..
"/*.hpp)"), change the pattern to include recursive matches (e.g. use /**.hpp
instead of /* .hpp) so add_headerfiles uses "src/(" .. path.filename(file) ..
"/**.hpp)"; keep the same loop and path.filename usage but replace the glob to
ensure nested headers are picked up.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 252cc044-076d-46de-927c-6b5e127ef0b2

📥 Commits

Reviewing files that changed from the base of the PR and between d84a2b0 and a8285c4.

📒 Files selected for processing (4)

• src/engine/xmake.lua
• src/plugin/camera-movement/xmake.lua
• src/plugin/graphic/src/system/initialization/ConfigureSurface.cpp
• src/plugin/physics/xmake.lua

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud