Value.cc: Remove invalid bool and pointer conversions to double #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCount
pushed a commit
to Homebrew/formula-patches
that referenced
this pull request
Sep 10, 2017
Correct broken implicit conversions which no longer work with a C++11 compiler. Required to build with Xerces-C 3.2.0. See Enigma-Game/Enigma#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few instances of bugs in the engima sources which broke compilation with a C++11 compiler, mainly related to illegal conversions. Patches attached.
This occurred when building with Xerces-C 3.2.0 with C++11 support for char16_t strings enabled.