plugin breaks provider.deploymentBucket

[christophgysin]

If setting:

plugins:
  - serverless-plugin-optimize
provider:
  name: aws
  deploymentBucket: my-deployment-bucket

deployment fails with:

Serverless: Validating template...

  Error --------------------------------------------------

  The CloudFormation template is invalid: Template format error: Unresolved resource dependencies [ServerlessDeploymentBucket] in the Resources block of the template

Looking at the generated CloudFormation template:

--- cloudformation-template-update-stack.json   2017-08-03 16:26:54.695489014 +0300
+++ cloudformation-template-update-stack.json   2017-08-03 16:04:48.612095055 +0300
@@ -86,11 +86,13 @@
       "Type": "AWS::Lambda::Function",
       "Properties": {
         "Code": {
-          "S3Bucket": "my-deployment-bucket",
-          "S3Key": "serverless/serverless-simple-http-endpoint/dev/1501766814665-2017-08-03T13:26:54.665Z/serverless-simple-http-endpoint.zip"
+          "S3Bucket": {
+            "Ref": "ServerlessDeploymentBucket"
+          },
+          "S3Key": "serverless/serverless-simple-http-endpoint/dev/1501765330724-2017-08-03T13:02:10.724Z/serverless-simple-http-endpoint.zip"
         },
         "FunctionName": "serverless-simple-http-endpoint-dev-currentTime",
-        "Handler": "handler.endpoint",
+        "Handler": "_optimize/serverless-simple-http-endpoint-dev-currentTime/handler.endpoint",
         "MemorySize": 1024,
         "Role": {
           "Fn::GetAtt": [

It seems that the plugin interferes with the S3Bucket definition.

[goncaloneves]

@christophgysin this is happening when individually is false and the stack is not yet created. This is related to last commit to run optimize plugin outside that.

I will see if I find a fix for this, until then use individually to true that's it is much better to shrink your lambda container size to the minimum.

[goncaloneves]

@christophgysin Fix for this in the latest release. Thanks for reporting this.

[christophgysin]

Thanks for the quick fix!