Skip to content

Conversation

@tdraier
Copy link
Collaborator

@tdraier tdraier commented Jun 29, 2017

ObjectFunction.getTypeName() generates a name using getName() instead of getSimpleName(), as everywhere else - this is ok as long as it is internal to this class, but this leads to an error when a GraphQLTypeReference is created. A reference to an invalid name is created and the schema cannot be built.

@tdraier
Copy link
Collaborator Author

tdraier commented Jun 30, 2017

Actually, with #94 , getTypeName() method is not used anymore and could simply be removed from the TypeFunction interface, along with the buildType(String typeName, Class<?> aClass, AnnotatedType annotatedType) method. That would make the interface more clear and easier to implement.

@guy120494
Copy link
Contributor

Do you have any idea why there are 2 tests that fail? when I run the tests with Intellij, everything is fine, but with gradle 2 tests fail.

@guy120494
Copy link
Contributor

Ok, i figured it out. The problem was that when you run all the tests with maven, the types we define in different tests are not getting deleted (because we use graphqlannotations.object which is static)
But in Intellij, the tests are run separately so the types are not saved. My solution was to use graphqlannotations.getObject instead of graphqlannotations.object in the failed tests (which is not static) and all work fine.

@guy120494
Copy link
Contributor

guy120494 commented Sep 14, 2017

I will merge this PR (until I have the time to look at #94 )

@guy120494 guy120494 merged commit b72ccde into Enigmatis:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants