Skip to content

Conversation

sgiorgetti
Copy link
Contributor

@sgiorgetti sgiorgetti commented Sep 11, 2024

Description

Centralising the copyright string with the year into the NOTICE file, and fixing the existing LICENSE file, to avoid massive update of the year across the repo.

Use case

Every year the copyright must be updated. Because the copyright info - for historical reason - is contained in many files, the procedure is risky and annoying.
By centralising the year bit into a single NOTICE file, the entire updating procedure becomes trivial.

Benefits

Centralising the copyright string with the year into the NOTICE file, and fixing the existing LICENSE file, to avoid massive update of the year across the repo.
The copyright update will be easier to do and check.

Possible Drawbacks

None

Testing

Added housekeeping_apache2.t for checking the header license and copyright information are good.
Discovered a few files missing the header (within the t directory), and fixed them.

@sgiorgetti sgiorgetti marked this pull request as ready for review September 13, 2024 11:08
Copy link
Contributor

@nwillhoft nwillhoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to centralise the copyright information into the NOTICE file. Build checks are also passing.

@sgiorgetti sgiorgetti merged commit 688d16f into main Sep 18, 2024
2 checks passed
@sgiorgetti sgiorgetti deleted the copyright-optim branch September 18, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants