Schema update 3.0 #169
Schema update 3.0 #169
Conversation
Includes three scripts for moving txt/sql files to a mysql server and dumping them back as sqlite. The conftest.py has options for running with the sqlite db A second commit will follow with deletion of all mysql related testing
Includes three scripts for moving txt/sql files to a mysql server and dumping them back as sqlite. The conftest.py has options for running with the sqlite db A second commit will follow with deletion of all mysql related testing
Implemented assembly uuid control Genome group support Simplified lookups for data moved to genome table Alias loading Assembly accession loading genebuild.version removed from updater multiple meta of same type allowed Checks for single only meta keys Fix for meta key verification
dpopleton
requested review from
JAlvarezJarreta,
bilalebi,
jonk-ebi,
nwillhoft,
sgiorgetti and
vinay-ebi
JAlvarezJarreta
left a comment
JAlvarezJarreta
left a comment
There was a problem hiding this comment.
Partial review, more to follow soon.
JAlvarezJarreta
left a comment
JAlvarezJarreta
left a comment
There was a problem hiding this comment.
Almost there, only 2 files and a half left.
JAlvarezJarreta
left a comment
JAlvarezJarreta
left a comment
There was a problem hiding this comment.
Almost there, only 2 files and a half left.
| self, | ||
| genome: Genome, | ||
| release_id: int, | ||
| release_type: str |
There was a problem hiding this comment.
| self, | |
| genome: Genome, | |
| release_id: int, | |
| release_type: str | |
| self, | |
| genome: Genome, | |
| release_id: int, | |
| release_type: str |
| self, | ||
| genome: Genome |
There was a problem hiding this comment.
| self, | |
| genome: Genome | |
| self, | |
| genome: Genome |
JAlvarezJarreta
left a comment
JAlvarezJarreta
left a comment
There was a problem hiding this comment.
A few changes left, but given the size of the PR, great work!
I would also suggest to split src/tests/test_exports.py in 3 files, one with each class, so reduce the amount of lines in a single file.
JAlvarezJarreta
left a comment
JAlvarezJarreta
left a comment
There was a problem hiding this comment.
A few changes left, but given the size of the PR, great work!
I would also suggest to split src/tests/test_exports.py in 3 files, one with each class, so reduce the amount of lines in a single file.
Here is a long one with many significant changes.
Sorry for the length.