-
Notifications
You must be signed in to change notification settings - Fork 2
Improve code logic and add fetch genome by ensembl and assembly name #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @dpopleton for your suggestions, I pushed the required changes |
|
Hi @vinay-ebi
|
Hi @bilalebi , changes look good to me, let @dpopleton have the final look |
dpopleton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So a few minor comments. It looks good for the most part. I have not tested it further or checked for conflicts , so I hope you have. :)
…deleted is_released
All recommendations implemented as requested
JIRA Ticket
https://www.ebi.ac.uk/panda/jira/browse/EA-1090
Changes
Added the possibility to fetch genome by
ensembl_nameandassembly_name(genebuild_idwill be added in the future)Update:
This branch is also used to update the API to be used by ensembl-metadata-service
Related PR:
Ensembl/ensembl-metadata-service#25