Checksum name incorrect #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code had `sha512t4u`, but the algorithm is `sha512t24u`. This fixes the name
Contributor
|
Hello @bilalebi do you have a version of grpc working with previous tag before I merge this one to main? or are you still depending on main? |
Contributor
Hi @marcoooo , the main gRPC branch is pointing to 1.2.0.dev2, I'll double check with @kamaldodiya on web's end |
We are on 0.0.4 for production and on 0.0.6a5 for staging, internal |
bilalebi
approved these changes
Oct 30, 2023
veidenberg
reviewed
Nov 10, 2023
marcoooo
pushed a commit
that referenced
this pull request
Jan 18, 2024
Fix alternative_names containing None and add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code had
sha512t4u, but the algorithm issha512t24u. This fixes the name