Ensured that the name of assembly sequences is assembly_sequence_name… #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Stored the production name as an attriubte
marcoooo
suggested changes
Oct 23, 2023
marcoooo
reviewed
Oct 24, 2023
-metadata grab was added to a dictionary -transferred attibutes to variables -General bug fixes -removed return new and added new test
marcoooo
reviewed
Oct 30, 2023
src/tests/test_updater.py
Outdated
| assert dataset.dataset_type.name == "genebuild" | ||
|
|
||
| # | ||
| # Just this one!. |
Contributor
There was a problem hiding this comment.
not sure about the meaning of this comment :-)
Contributor
Author
There was a problem hiding this comment.
Shouldn't have been left in.
marcoooo
approved these changes
Oct 30, 2023
marcoooo
added a commit
that referenced
this pull request
Jan 18, 2024
updated dependencies to retrieve what's new from ensembl-py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapped logic to use seq_region.name as each sequences name.
Stored the production name as an attribute