Feature/post mvp updates #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are not fully implemented
…s are not fully implemented
…, force, and genome_uuid
# Conflicts: # requirements.in # requirements.txt # src/ensembl/production/metadata/api/sample/ensembl_metadata/genome.txt
…el when exception is encountered.
marcoooo
suggested changes
Dec 11, 2023
Contributor
marcoooo
left a comment
marcoooo
left a comment
There was a problem hiding this comment.
Best to keep ensembl_name as a alias. So GRPC will still be compatible.
marcoooo
suggested changes
Dec 11, 2023
marcoooo
suggested changes
Dec 12, 2023
marcoooo
suggested changes
Dec 12, 2023
Contributor
marcoooo
left a comment
marcoooo
left a comment
There was a problem hiding this comment.
On last change and we are good to go!
marcoooo
approved these changes
Dec 12, 2023
marcoooo
added a commit
to Ensembl/ensembl-metadata-admin
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main feature update and bugfix:
Modified update method to only alter dataset attributes and to maintain dataset uuids
Implemented genome_uuid check and insertion into the core databases
Added the -force flag
Added method for API entry point.
This PR has full coverage with the exception of the failed insertion of genome_uuid into a core database.