Skip to content

Conversation

@bilalebi
Copy link
Contributor

@bilalebi bilalebi commented Jan 19, 2024

JIRA Ticket

https://www.ebi.ac.uk/panda/jira/browse/EA-1130

Changes

  • Replaced ensembl_name with production_name for GetGenomeUUID endpoint.
  • Removed ensembl_name from GetOrganismsGroupCount() endpoint

Examples

Query 1
{
	"production_name": "homo_sapiens",
	"assembly_name": "GRCh38",
	"use_default": true
}
Response 1
{
	"genome_uuid": "a7335667-93e7-11ec-a39d-005056b38ce3"
}
Query 2
{
	"production_name": "homo_sapiens",
	"assembly_name": "GRCh38.p14",
	"use_default": false
}
Response 2
{
	"genome_uuid": "a7335667-93e7-11ec-a39d-005056b38ce3"
}

  • Removed ensembl_name from GetOrganismsGroupCount() endpoint

Example

Query
{}
Response
{
	"organisms_group_count": [
		{
			"species_taxonomy_id": 9606,
			"common_name": "human",
			"scientific_name": "Homo sapiens",
			"order": 1,
			"count": 99
		},
		{
			"species_taxonomy_id": 10090,
			"common_name": "mouse",
			"scientific_name": "Mus musculus",
			"order": 2,
			"count": 16
		},
               ...
       ]
}

  • TODO: Replace deprecated Organism.ensembl_name with Organism.biosample_id (Will do later in a separate PR)

@bilalebi bilalebi self-assigned this Jan 19, 2024
@bilalebi bilalebi marked this pull request as ready for review January 19, 2024 17:32
@bilalebi bilalebi requested a review from marcoooo January 22, 2024 09:46
@bilalebi bilalebi changed the title replace ensembl_name with production_name for GetGenomeUUID endpoint [gRPC] Replace ensembl_name with production_name for GetGenomeUUID endpoint Jan 24, 2024
Copy link
Contributor

@marcoooo marcoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be need a discussion on slack / zoom

@bilalebi bilalebi merged commit 15b7c46 into main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants