Skip to content

Conversation

@bilalebi
Copy link
Contributor

@bilalebi bilalebi commented Jan 23, 2024

JIRA Ticket

https://www.ebi.ac.uk/panda/jira/browse/EA-1142

Changes

  • Added GetReleaseVersionByUUID() endpoint and test
  • renamed dataset_type param in the adaptor to dataset_type_name to avoid confusion

Example

Query

All queries below will return the same response

{
	"genome_uuid": "a73351f7-93e7-11ec-a39d-005056b38ce3"
}
{
	"genome_uuid": "a73351f7-93e7-11ec-a39d-005056b38ce3",
	"data_type": "genebuild"
}
{
	"genome_uuid": "a73351f7-93e7-11ec-a39d-005056b38ce3",
	"data_type": "genebuild",
	"release_version": 110.1
}
{
	"genome_uuid": "a73351f7-93e7-11ec-a39d-005056b38ce3",
	"data_type": "genebuild",
	"release_version": 115.3
}

Response

{
	"release_version": 110.1
}

@bilalebi bilalebi self-assigned this Jan 23, 2024
@bilalebi bilalebi marked this pull request as ready for review January 24, 2024 09:20
@bilalebi bilalebi requested a review from marcoooo January 24, 2024 09:20
Copy link
Contributor

@marcoooo marcoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be a good time to introduce logging in Metadata GRPC services?

@bilalebi
Copy link
Contributor Author

May be a good time to introduce logging in Metadata GRPC services?

@marcoooo I've replaced print statement with the logger in the adaptor, as for introducing logging, I will create a dedicated PR for that because I would like to go through the code and tidy it up :)

@bilalebi bilalebi merged commit dbfeeed into main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants