[gRPC] Fix ALLOW_UNRELEASED and add logging #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilalebi
changed the title
marcoooo
reviewed
Jan 25, 2024
marcoooo
reviewed
Jan 25, 2024
marcoooo
reviewed
Jan 25, 2024
marcoooo
suggested changes
Jan 25, 2024
marcoooo
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ALLOW_UNRELEASED:export ALLOW_UNRELEASED=Whatever_we_put_herewill be evaluated as a string not boolean => Fixedis_genome_releasedandALLOW_UNRELEASEDare bothFalsegRPC will still return unreleased data (addingelse: return []did the trick)DEBUGcan be turned ON and OFF using environment variable)