Moved reflection package yagrc to test. #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dataset status enum Removed `yield` from service start up method Moved Config in server() Added Configurable service port
bilalebi
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dataset status enum
Removed
yieldfrom service start up methodMoved Config in server()
Added Configurable service port
For some reason
serve()method failed to run with theyieldkeyword. From https://github.com/grpc/grpc/blob/master/examples/python/wait_for_ready/wait_for_ready_with_client_timeout_example_server.py it seems like it's not necessary so I removed it. Now the Docker container run as expected.I took this chance as well to make the
service_portconfigurable with default to standard 50051 one.