Updates/dataset factory updater #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed assembly sequence reload bug Fixed a few associated tests that had been commented out
Updated source to handle compara Added homology dataset creation Upper case for common name Default species taxonomy id Fixed broken tests Added license for genome_uuid_manager.py
marcoooo
suggested changes
Mar 12, 2024
vinay-ebi
reviewed
Mar 12, 2024
marcoooo
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes several small issues:
species taxonomy id will be populated and common name will be present.
It also uses the dataset factory for dataset creation and creates homology datasets as well.
The previously broken tests have been fixed, but will need future work as they are interdependent.