Revert "prevent event propagation on icon click (#1036)"#1043
Merged
anserwaseem merged 1 commit intomainfrom Feb 17, 2025
Merged
Revert "prevent event propagation on icon click (#1036)"#1043anserwaseem merged 1 commit intomainfrom
anserwaseem merged 1 commit intomainfrom
Conversation
This reverts commit 94b90eb.
🦋 Changeset detectedLatest commit: aa97c51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Visit the preview URL for this PR (updated for commit aa97c51): https://react-kitchen-sink-dev--pr1043-anserwaseem-revert-i-86uht8xf.web.app (expires Mon, 24 Feb 2025 14:16:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
evshi
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 94b90eb.
Describe your changes
Original usecase was that if Icon is used under Collapsible widget, tapping on Icon was toggling Collapsible too.
But this way endingIcon in Button widget doesn't work.
So, reverting it now, will have to use Button with empty label and endingIcon in original usecase.
Screenshots [Optional]
Revert PR
#1036
Checklist before requesting a review
pnpm changeset add