Skip to content

fix: add support for FirebaseResponse in onError handling#2183

Merged
usmandevx merged 1 commit intomainfrom
fix/issues-1801-firestore-error-handling
Apr 3, 2026
Merged

fix: add support for FirebaseResponse in onError handling#2183
usmandevx merged 1 commit intomainfrom
fix/issues-1801-firestore-error-handling

Conversation

@usmandevx
Copy link
Copy Markdown
Contributor

Summary

Add support for Firebase (FirestoreResponse) in API error handling

Key Changes

Error Handling

  • Include FirestoreResponse in the same error handling flow as HttpResponse
  • Ensure Firebase errors are processed, scoped, and dispatched consistently
  • Remove redundant branching by unifying response handling

Expected Behavior

  • Firebase API errors are handled the same way as HTTP errors
  • Error state, response data, and dispatch flow remain consistent across API types
  • Improved reliability and maintainability of error handling logic

@usmandevx usmandevx requested a review from TheNoumanDev April 2, 2026 22:03
@usmandevx usmandevx self-assigned this Apr 2, 2026
@usmandevx usmandevx linked an issue Apr 2, 2026 that may be closed by this pull request
@usmandevx usmandevx changed the title fix(invoke_api_action): handle FirestoreResponse in error handling fix: Add support for firebase response on-error Apr 2, 2026
@usmandevx usmandevx changed the title fix: Add support for firebase response on-error add support for FirebaseResponse in onError handling Apr 2, 2026
@usmandevx usmandevx changed the title add support for FirebaseResponse in onError handling fix: add support for FirebaseResponse in onError handling Apr 2, 2026
@usmandevx usmandevx merged commit 16afd98 into main Apr 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for proper error handling for Firestore responses

2 participants