Skip to content

fix(storage): defer binding updates until ensemble.storage.clear() completes #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(storage): defer binding updates until ensemble.storage.clear() completes #2231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions modules/ensemble/lib/framework/data_context.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,10 +800,14 @@ class EnsembleStorage with Invokable {
void clear() {
final keys =
ensembleStorageClearDispatchKeys(StorageManager().getKeys());
StorageManager().clearPublicStorage();
for (final key in keys) {
ScreenController().dispatchStorageChanges(context, key, null);
}
// clearPublicStorage is async; binding listeners re-evaluate by reading
// GetStorage. Dispatch only after removal completes so eval() does not
// observe stale persisted values (see PR discussion on #2227).
unawaited(StorageManager().clearPublicStorage().whenComplete(() {
for (final key in keys) {
ScreenController().dispatchStorageChanges(context, key, null);
}
}));
}

@override
Expand Down
Loading