IBM - DBDAART-15627 & DBDAART-15629: PRV & MCP TMSIS Views #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert PRV build process from using TMSIS tables to using TMSIS views.
Convert MCP build process from using TMSIS tables to using TMSIS views.
Create separate fix_old_dates and zero_pad functions in TAF_Closure to permit column renames for MCP/PRV, rather than adding a conditional to functions shared by claims, which would unnecessarily increase run time.
fumanjie
requested review from
MemeBarrett,
XiaoBarry,
a-pfeiffer,
alihashmi-wh and
hls0231
Contributor
|
I reviewed the code with Manjie. Note that the PRV & MCP specs in Confluence include this change. |
hls0231
approved these changes
Sep 22, 2025
Contributor
|
@a-pfeiffer @XiaoBarry Can you approve this when ready? We don't need to do it for the October run, but afterwards. IBM owns this and has completed their review. |
a-pfeiffer
approved these changes
Oct 2, 2025
XiaoBarry
approved these changes
Oct 2, 2025
Rebase prior to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting 1 approval from IBM, followed by 1 approval from Mathematica.
Please approve, but do not submit the PR, thanks!
What is this and why are we doing it?
DBDAART-15627
Convert PRV build process from pulling input data from TMSIS tables to doing so from their respective views.
DBDAART-15629
Convert MCP build process from pulling input data from TMSIS tables to doing so from their respective views.
What are the security implications from this change?
N/A
How did I test this?
Ran TAF builds with these code changes using synthetic TMSIS data, compared against runs with code currently used in production on the same data, with identical results.
Should there be new or updated documentation for this change? (Be specific.)
Documentation has been covered elsewhere.
PR Checklist