Remove dangling CurrentTransaction properties that always return null

[Copilot]

After the caller-owned transaction refactoring in f42b3e6, BLiteEngine.CurrentTransaction and DocumentDbContext.CurrentTransaction became dead code hardwired to null, silently breaking any code that read the property after calling BeginTransaction().

Changes

• IDocumentDbContext — removes ITransaction? CurrentTransaction { get; } from the interface contract
• BLiteEngine / DocumentDbContext — removes the => null stub implementations
• BLiteEngineAdditionalTests — removes three tests that asserted the property was null (now stale)
• WHATS_NEW_4.3.md — drops CurrentTransaction from the documented interface snippet

BLiteSession.CurrentTransaction is unchanged — it tracks a real per-session transaction and remains valid.

Migration

// ❌ Broken in 4.3 — CurrentTransaction was always null
db.BeginTransaction();
var tx = db.CurrentTransaction;

// ✅ Correct pattern — capture the return value directly
var tx = db.BeginTransaction();

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• av-build-tel-api-v1.avaloniaui.net
  • Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll 20' --output-dircredential.username (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

Removes the now-dead CurrentTransaction API surface from BLiteEngine/DocumentDbContext and from IDocumentDbContext, after the caller-owned transaction refactor made those properties permanently null.

Changes:

• Remove ITransaction? CurrentTransaction { get; } from IDocumentDbContext.
• Remove the => null stub CurrentTransaction implementations from BLiteEngine and DocumentDbContext.
• Remove stale tests asserting BLiteEngine.CurrentTransaction is null, and update the 4.3 “what’s new” interface snippet accordingly.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/BLite.Tests/BLiteEngineAdditionalTests.cs	Deletes stale tests that asserted engine-level CurrentTransaction was null.
src/BLite.Core/IDocumentDbContext.cs	Removes CurrentTransaction from the public interface contract.
src/BLite.Core/DocumentDbContext.cs	Removes CurrentTransaction stub property returning null.
src/BLite.Core/BLiteEngine.cs	Removes CurrentTransaction stub property returning null.
WHATS_NEW_4.3.md	Updates the documented IDocumentDbContext snippet to no longer include CurrentTransaction.

Comments suppressed due to low confidence (1)

tests/BLite.Tests/BLiteEngineAdditionalTests.cs:231

• This test is named as if it covers the synchronous BeginTransaction(), but it actually calls BeginTransactionAsync(). Either update the test to call BeginTransaction() or rename it so it matches what is being exercised; otherwise it can mask regressions in the sync API.

    public async Task BeginTransaction_ReturnsActiveTransaction()
    {
        var txn = await _engine.BeginTransactionAsync();
        Assert.NotNull(txn);
        Assert.Equal(TransactionState.Active, txn.State);

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.