refactor(core): remove docker.base_commit, consume repo checkout state directly#1006
Merged
refactor(core): remove docker.base_commit, consume repo checkout state directly#1006
Conversation
…e directly Remove the deprecated `workspace.docker.base_commit` compatibility bridge. The repo-checkout model (`workspace.repos[].checkout`) is now the sole source of truth for checkout state. Make `source` and `path` optional on `RepoConfig` to support Docker prebuilt images where repos exist inside the container without needing a clone source. - Remove `base_commit` from DockerWorkspaceConfig type, schema, parser, and validator deprecation warning - Make `source` and `path` optional on RepoConfig type and schema - Update parseRepoConfig() to handle optional source/path - Add validation: source-less repos require workspace.docker config - Remove this.config.base_commit fallback in resetContainerCheckout() - Guard host materialization (RepoManager, PoolManager) against source-less repos - Update SWE-bench importer to emit workspace.repos[].checkout - Update tests, docs, skill reference, and regenerate eval-schema.json Closes #993 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying agentv with
|
| Latest commit: |
270176e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae3632a4.agentv.pages.dev |
| Branch Preview URL: | https://refactor-993-docker-checkout.agentv.pages.dev |
- Fix stale docstring in import-huggingface.py field mapping - Use `repo.path ?? '(none)'` in all validator location strings - Update stale test name and JSDoc referencing removed base_commit Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace.docker.base_commitcompatibility bridge — the repo-checkout model (workspace.repos[].checkout) is now the sole source of truthsourceandpathoptional onRepoConfigto support Docker prebuilt images where repos exist inside the containerworkspace.dockerconfig; guard host materialization against source-less reposworkspace.repos[].checkout.base_commitinstead ofworkspace.docker.base_commitTest plan
bun run test)bun run build)bun run typecheck)bun run lint)bun run validate:examples)workspace.repos[].checkout.base_commit+ Docker imageCloses #993
🤖 Generated with Claude Code