fix(core): probe global npm roots when resolving copilot cli#1038
Merged
fix(core): probe global npm roots when resolving copilot cli#1038
Conversation
Windows copilot-cli targets failed with `spawn copilot ENOENT` when the `@github/copilot` package was installed globally via `npm install -g`. `import.meta.resolve` and the local node_modules walk-up could not find the platform binary, so the resolver fell back to plain `copilot`, which is not directly spawnable (the PATH entry is a `.ps1`/`.cmd` shim). `resolvePlatformCliPath()` now probes common global npm install roots (APPDATA/npm on Windows, /usr/local, homebrew, ~/.npm-global on Unix, plus any `npm_config_prefix` override), checking both the hoisted and nested `@github/copilot/node_modules` layouts before giving up. Closes #1036 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying agentv with
|
| Latest commit: |
3ef483a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3c28d1e9.agentv.pages.dev |
| Branch Preview URL: | https://fix-1036-copilot-win-resolve.agentv.pages.dev |
The tests mutated process.env/cwd and silently no-opped on non-Windows runners, giving little real coverage beyond the manual red/green UAT documented on the PR. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Repeatable manual acceptance check for #1036. Run from outside the repo so the local node_modules walk-up cannot mask a regression. Exits non-zero when `resolvePlatformCliPath()` returns undefined. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
spawn copilot ENOENTon Windows when@github/copilotis installed globally vianpm install -g.resolvePlatformCliPath()now probes common global npm install roots (APPDATA/npm on Windows, /usr/local, homebrew, ~/.npm-global on Unix, plus anynpm_config_prefixoverride) and checks both the hoisted and nested@github/copilot/node_moduleslayouts.Closes #1036
Red/green UAT (Windows)
Running
resolvePlatformCliPath()from a cwd outside the workspace (so the local walk-up cannot match) against an unchanged global copilot install:Red (main @ ddc44e8):
With
executable: copilotthis falls through tospawn('copilot')→ENOENT, matching the issue repro.Green (this branch):
Tests
packages/core/test/evaluation/providers/copilot-utils-resolve.test.ts— 3 new tests covering the%APPDATA%\npm\node_moduleslayout,npm_config_prefix, and the nested@github/copilot/node_moduleslayout.bun run test): 1479 pass / 0 fail.Test plan
/usr/local/lib/node_modules