fix(core): honor reset-only workspace hooks#1060
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
543b2e8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3c0de713.agentv.pages.dev |
| Branch Preview URL: | https://fix-1058-before-each-reset.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1058
Summary
before_eachhooks during eval execution instead of silently ignoring thembefore_eachsetup scripts so setup artifacts do not leak intofile_changesRed/Green E2E
Red on
main:bun apps/cli/src/cli.ts eval run D:\GitHub\christso\agentv-e2e-1058\repro.eval.yaml --output D:\GitHub\christso\agentv-e2e-1058-out-main --workers 1D:\GitHub\christso\agentv-e2e-1058-out-main\repro\case-1\grading.jsonreportedworkspace_changes.diff_summaryforsetup.txt, even though that file was written by thebefore_eachhook rather than the agent.Green on this branch:
bun apps/cli/dist/cli.js eval run D:\GitHub\christso\agentv-e2e-1058\repro.eval.yaml --output D:\GitHub\christso\agentv-e2e-1058-out-fix --workers 1D:\GitHub\christso\agentv-e2e-1058-out-fix\repro\case-1\grading.jsonno longer containsworkspace_changes; thebefore_eachsetup file is excluded fromfile_changesas intended.Verification
bun test packages/core/test/evaluation/orchestrator.test.ts packages/core/test/evaluation/validation/eval-validator.test.tsbun run buildbun run teststill has one unrelated timeout inpipeline grade > writes code_grader_results/<name>.json with score