fix(core): allow mode=static with no repos and no path#1083
Merged
Conversation
When workspace.mode=static is set without workspace.path and there are no repos, fall back to temp mode instead of erroring. The static mode's purpose is to skip repo cloning, which is already a no-op when there are no repos. Closes #1082 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying agentv with
|
| Latest commit: |
f532755
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://43399506.agentv.pages.dev |
| Branch Preview URL: | https://fix-1082-static-mode-no-path.agentv.pages.dev |
Collaborator
Author
Red/Green UATEval file ( workspace:
mode: static
tests:
- id: test1
input: "Say hello"
assert:
- type: contains
value: helloRED (main) — setup error{"execution_status":"execution_error","error":"workspace.mode=static requires workspace.path or --workspace-path","failure_stage":"setup"}GREEN (fix branch) — eval runs successfully{"execution_status":"quality_failure","scores":[{"name":"contains-hello","type":"contains","score":0,"verdict":"fail"}]}The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace.mode=staticis set withoutworkspace.pathand there are norepos, fall back totempmode instead of erroringstaticmode's purpose is to skip repo cloning, which is already a no-op when there are no repos — so the path requirement is unnecessary in this caseChanges
packages/core/src/evaluation/orchestrator.ts: Move theuseStaticWorkspacederivation after the new fallback check. Whenmode=static+ no path + no repos, downgradeconfiguredModetotempso a temp directory is created automaticallypackages/core/test/evaluation/orchestrator.test.ts: Updated existing test to verify the error still fires when repos are present; added new test verifying the fallback succeeds with no reposTest plan
mode=staticwithout path with repos still errorsmode=staticwithout path and without repos falls back to temp mode and succeedsCloses #1082
🤖 Generated with Claude Code