Skip to content

feat(core): rename total_budget_usd to budget_usd#1117

Merged
christso merged 1 commit intomainfrom
feat/1114-rename-budget-usd
Apr 15, 2026
Merged

feat(core): rename total_budget_usd to budget_usd#1117
christso merged 1 commit intomainfrom
feat/1114-rename-budget-usd

Conversation

@christso
Copy link
Copy Markdown
Collaborator

Summary

Renames execution.total_budget_usdexecution.budget_usd and suite.totalBudgetUsdsuite.budgetUsd across the entire codebase. No deprecation alias — the old key is rejected with a clear error message.

Closes #1114

Changes

  • Schema (eval-file.schema.ts): Renamed Zod fields
  • Config loader (config-loader.ts): Renamed extractTotalBudgetUsdextractBudgetUsd, added old-key rejection
  • YAML parser (yaml-parser.ts): Updated interface and assignment
  • Orchestrator (orchestrator.ts): Renamed interface field and all usages
  • CLI (run-eval.ts): Renamed across interfaces and propagation
  • Tests: Updated all fixtures + 2 new rejection tests
  • JSON schema (eval-schema.json): All occurrences renamed

E2E Verification

Red (old key rejected):

$ bun apps/cli/src/cli.ts eval test-old-key.eval.yaml --dry-run
Error: execution.total_budget_usd has been renamed to execution.budget_usd. Update your eval YAML.

Green (new key accepted):

$ bun apps/cli/src/cli.ts eval test-new-key.eval.yaml --dry-run
# No budget-related error — proceeds to target resolution

Test Results

472/472 pass, 0 failures

Rename execution.total_budget_usd → execution.budget_usd (and
totalBudgetUsd → budgetUsd) across schema, config-loader, yaml-parser,
orchestrator, CLI, tests, and JSON schema reference.

The old key is rejected at load time with a clear error message:
"execution.total_budget_usd has been renamed to execution.budget_usd.
Update your eval YAML."

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@christso christso merged commit 491066f into main Apr 15, 2026
3 of 4 checks passed
@christso christso deleted the feat/1114-rename-budget-usd branch April 15, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename execution.total_budget_usd → execution.budget_usd (and suite.totalBudgetUsd → suite.budgetUsd)

1 participant