Skip to content

fix(cli): drop outputFormat from interactive wizard rawOptions#1147

Merged
christso merged 1 commit intomainfrom
fix/interactive-output-format-warning
Apr 22, 2026
Merged

fix(cli): drop outputFormat from interactive wizard rawOptions#1147
christso merged 1 commit intomainfrom
fix/interactive-output-format-warning

Conversation

@christso
Copy link
Copy Markdown
Collaborator

Summary

Running agentv eval run with no eval path (the interactive wizard) printed:

Warning: --output-format is deprecated. The artifact directory always uses JSONL.

…even though the user never passed --output-format. The wizard's executeConfig/promptRetryErrors hard-coded outputFormat: 'jsonl' in the rawOptions it forwarded to runEvalCommand, which then tripped the deprecation warning meant for real user flags.

Drop the field from both rawOptions blobs. JSONL is the only supported artifact format, so this is purely dead weight.

Red / Green evidence

Red (simulated via explicit --output-format jsonl, which is what the wizard was implicitly doing):

$ bun apps/cli/src/cli.ts eval run /tmp/tiny-eval.yaml --dry-run --output-format jsonl 2>&1 | grep deprecated
Warning: --output-format is deprecated. The artifact directory always uses JSONL.

Green (same eval, no explicit flag — matches the new wizard behavior):

$ bun apps/cli/src/cli.ts eval run /tmp/tiny-eval.yaml --dry-run 2>&1 | grep deprecated
(no output)

Additionally, a direct call to runEvalCommand with the old wizard rawOptions shape vs the new one confirms the diff:

RED  (old wizard rawOptions with outputFormat: 'jsonl'): hadWarning=true
GREEN (new wizard rawOptions, no outputFormat):          hadWarning=false

The warning still fires correctly when a user explicitly passes --output-format on the CLI, which is the intended behavior.

Test plan

  • bun run typecheck — passes
  • bun run lint — passes
  • bun --filter agentv test — 490 pass, 0 fail
  • Pre-push hook (build + typecheck + lint + test + validate:examples) — all passed on push
  • Red/green CLI verification captured above

🤖 Generated with Claude Code

The interactive `agentv eval run` wizard hard-coded `outputFormat: 'jsonl'`
in the rawOptions it forwarded to runEvalCommand. Since `--output-format`
is deprecated (JSONL is always used), this made the wizard trip its own
deprecation warning on every run:

  Warning: --output-format is deprecated. The artifact directory always uses JSONL.

Remove the field so the warning only fires when the user actually passes
`--output-format` on the CLI.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: feff84c
Status: ✅  Deploy successful!
Preview URL: https://1f7d2679.agentv.pages.dev
Branch Preview URL: https://fix-interactive-output-forma.agentv.pages.dev

View logs

@christso christso marked this pull request as ready for review April 22, 2026 00:59
@christso christso merged commit ac4b140 into main Apr 22, 2026
4 checks passed
@christso christso deleted the fix/interactive-output-format-warning branch April 22, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant