fix(cli): drop outputFormat from interactive wizard rawOptions#1147
Merged
fix(cli): drop outputFormat from interactive wizard rawOptions#1147
Conversation
The interactive `agentv eval run` wizard hard-coded `outputFormat: 'jsonl'` in the rawOptions it forwarded to runEvalCommand. Since `--output-format` is deprecated (JSONL is always used), this made the wizard trip its own deprecation warning on every run: Warning: --output-format is deprecated. The artifact directory always uses JSONL. Remove the field so the warning only fires when the user actually passes `--output-format` on the CLI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying agentv with
|
| Latest commit: |
feff84c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f7d2679.agentv.pages.dev |
| Branch Preview URL: | https://fix-interactive-output-forma.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
agentv eval runwith no eval path (the interactive wizard) printed:…even though the user never passed
--output-format. The wizard'sexecuteConfig/promptRetryErrorshard-codedoutputFormat: 'jsonl'in therawOptionsit forwarded torunEvalCommand, which then tripped the deprecation warning meant for real user flags.Drop the field from both rawOptions blobs. JSONL is the only supported artifact format, so this is purely dead weight.
Red / Green evidence
Red (simulated via explicit
--output-format jsonl, which is what the wizard was implicitly doing):Green (same eval, no explicit flag — matches the new wizard behavior):
Additionally, a direct call to
runEvalCommandwith the old wizardrawOptionsshape vs the new one confirms the diff:The warning still fires correctly when a user explicitly passes
--output-formaton the CLI, which is the intended behavior.Test plan
bun run typecheck— passesbun run lint— passesbun --filter agentv test— 490 pass, 0 fail🤖 Generated with Claude Code