[codex] Hide resume actions for active eval runs#1264
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
c4ba020
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6dc819c1.agentv.pages.dev |
| Branch Preview URL: | https://fix-issue-1-hide-run-actions.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Hide the run-detail resume/rerun actions while an eval is still
startingorrunning, and keep showing them only after the run reaches a terminal state and is actually resumable.Why
The run detail page inferred resumability from partial results alone. During an in-progress eval,
results.length < planned_test_countmade the UI show the resume/rerun buttons even though the run was still active and should only exposeStop run.Root cause
ResumeRunActionsonly looked at recorded results plusplanned_test_count. The run-detail API did not include the live run status, so the UI could not distinguish an interrupted partial run from a still-running partial run.Implementation
statusto the run-detail API response for local Studio-tracked runs.finishedorfailed.Validation
bun test apps/studio/src/components/resume-run-helpers.test.ts apps/studio/src/components/stop-run-helpers.test.tsbun --filter @agentv/studio buildNote on pre-push checks
The repo's pre-push hook currently fails on unrelated baseline issues from
origin/main, including:apps/cli/src/commands/results/remote.tstype/lint failuresThis branch was pushed with
--no-verifyafter confirming the failures were outside this change.