fix(config): complete layered home config migration#1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layered config is now consistently based on
$AGENTV_HOME/config.yaml: Dashboard deployment seeds the newprojects:registry shape, global validation no longer mistakes the real home config for a project-local config, andprojects[].resultsis validated with the same result-repo rules as top-levelresults.Project-scoped remote status now prefers registered project result settings over global fallback settings, so Dashboard deployments can keep per-project result repos in the home registry without
results_by_project.Verification
bun test packages/core/test/evaluation/validation/config-validator.test.tsbun test packages/core/test/projects.test.ts apps/cli/test/commands/results/serve.test.tsbun run buildbun run typecheckbun run lintbash -n scripts/setup-dashboard-deployment.shagentv validateaccepts$AGENTV_HOME/config.yamlwithprojects:and no false project-local warning.agentv validate <project>/.agentv/config.yamlwarns thatprojects:is only valid in$AGENTV_HOME/config.yaml./api/projects/:id/remote/statusreturns the registeredprojects[].resultsrepo/path over the global fallback.scripts/setup-dashboard-deployment.sh --no-startwriteshome/config.yaml, does not writehome/projects.yaml, and preserves unrelated home config keys plus other project entries.