fix(results): keep dashboard status read-only for repo paths#1542
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
f44c39a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ba73a106.agentv.pages.dev |
| Branch Preview URL: | https://debug-dashboard-remote-corru.agentv.pages.dev |
214a8ed to
f44c39a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getResultsRepoSyncStatus()from fetching configured storage branches forrepo_path/same-checkout results configs.originURL and missingrefs/remotes/origin/agentv/results/v1untouched.Root cause / investigation
/api/config,/api/remote/status, and/api/projects/:id/remote/statusdid not rewrite a disposable repo origin tohttps://github.com/..git.https://github.com/..gitcorruption path was PR fix(results): push same-repo results to project origin, not a synthesized URL #1502-era results sync code:resolveResultsRepoUrl('.')synthesized the placeholder URL andensureResultsRepoRemote()rangit remote set-url. That path is already removed on current main.results.repo.path: .fetched the storage branch into the source checkout on page-load status polling. This did not rewriteorigin, but it did mutate source checkout Git refs from a read-only Dashboard status request.Red / green evidence
bun test ./packages/core/test/evaluation/results-repo.test.ts --test-name-pattern "does not fetch a repo_path storage branch during status inspection"failed becauserefs/remotes/origin/agentv/results/v1becamepresent.GET /api/remote/status: origin URL unchanged, remote results ref still absent, run_count 0.POST /api/remote/sync: origin URL unchanged, remote results ref present, run_count 1.Verification
bun test ./packages/core/test/evaluation/results-repo.test.ts --test-name-pattern "does not fetch a repo_path storage branch during status inspection"bun test ./packages/core/test/evaluation/results-repo.test.tsbun test ./apps/cli/test/commands/results/serve.test.ts --test-name-pattern "remote/status|remote/sync|project-scoped remote status"bun --filter @agentv/core typecheckbun --filter @agentv/core lintbun run buildgit remote -vin both worker and primary checkout remainedhttps://github.com/EntityProcess/agentv.gitfor fetch/push.Bead: av-0p9