refactor(marketplace): consolidate plugin resolution logic#34
Merged
Conversation
Extract resolvePluginSpecWithAutoRegister() into marketplace.ts as a single shared function used by workspace-modify, sync, and status. This removes ~160 lines of duplicated auto-register/resolve pipelines and fixes the missing marketplaceNameOverride bug in workspace-modify and status. Also accept allowed-tools as a string in skill metadata schema to match Claude Code behavior (normalizes to single-element array). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Deploying allagents with
|
| Latest commit: |
fb53a85
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4821c700.allagents.pages.dev |
| Branch Preview URL: | https://refactor-consolidate-plugin.allagents.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolvePluginSpecWithAutoRegister()intomarketplace.tsas a single shared function, replacing three independent implementations acrossworkspace-modify.ts,sync.ts, andstatus.ts(net -95 lines)marketplaceNameOverridebug inworkspace-modify.tsandstatus.tsthat prevented manifest-renamed marketplaces from resolving correctlyallowed-toolsas a string in skill metadata schema to match Claude Code behavior (normalizes to single-element array), fixing sync failure withagent-browserpluginTest plan
bun test— 257 tests passnpm run build— clean buildtsc --noEmit— clean typecheckallagents workspace plugin add agent-browser@agent-browser— auto-registers and syncs (1 file)allagents workspace plugin add development@WiseTechGlobal/WTG.AI.Prompts— auto-registers, normalizes spec todevelopment@wtg-ai-prompts, syncs (14 files)allagents workspace sync— both plugins resolve and sync cleanly (15 files, 0 failures)allagents workspace status— both plugins show as available🤖 Generated with Claude Code