fix: show version update notice on all commands#79
Merged
Conversation
The background version check previously only ran in the interactive TUI wizard. Commands like `allagents workspace sync` would never show an update notice. Replace the in-process npm fetch with a detached child process that survives process.exit(), and register a process exit handler in the CLI entry point so the notice appears after any subcommand output. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Deploying allagents with
|
| Latest commit: |
bf9b1a7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a53793ca.allagents.pages.dev |
| Branch Preview URL: | https://fix-update-check-all-command.allagents.pages.dev |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Register process.on('exit') handler synchronously to prevent race where
process.exit() fires before the cache file read resolves. Add
--input-type=commonjs flag to child process spawn for forward
compatibility with ESM-only Node runtimes.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Node defaults to CJS for -e scripts. The flag was a preemptive workaround for a hypothetical future change that would break half the ecosystem anyway. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backgroundUpdateCheck()with a detached child process that survivesprocess.exit()index.ts) for all subcommand invocations viaprocess.on('exit')handlerTest plan
bun test)allagents workspace statuswith a stale/missing cache and verify the background child populates~/.allagents/version-check.json🤖 Generated with Claude Code