Save selected theme

[ContemporaryInsanity]

Save selected theme

[RichieHindle]

Currently, each module remembers its theme within a session, so that the next time you create a new instance of a module, you get the same theme as the last instance of that module.

That's wrong on two counts, I think:

• The stored theme should be shared across all Entrian modules, in all plugins, rather than being stored per-module.
• The theme should be remembered between sessions.

That would mean that setting the theme on any module instance would then apply that theme to all future Entrian module instances in the current and all future sessions, until you set a different theme.

It would still be the case that changing the theme of a module instance wouldn't change the theme of any other existing module instances - you could still have different themes for different module instances if you like. I think that's correct.

Let me know if that's not what you had in mind.

[RichieHindle]

Nope, I respectfully disagree with the previous suggestion. 😃

I had a look at how other popular plugins do this, and Bogaudio stands out as having the best implementation - easy to understand but powerful enough to do everything you'd want:

• A module instance can be set to particular theme, or "Default".
• You set the default theme explicitly on the menu:

That means:

• You can directly, rather than implicitly, control the default.
• You can explicitly set some module instances to non-default themes without changing the default.
• When you change the default theme, existing module instances that are set to Default will change.
• If a future Rack version offers a global option like "Prefer dark themes", that will fit nicely.

Big hat-tip to Matt for this excellent design which, unless he objects (@mdemanett?), I will shamelessly steal. 😃

[ContemporaryInsanity]

I'm just grateful to all devs who cater for this, & remain forever boggled at you know who who doesn't...

Thank you :)

[mdemanett]

Big hat-tip to Matt for this excellent design which, unless he objects (@mdemanett?), I will shamelessly steal. 😃

Take it with my blessing. For the record, I stole it from @MarcBoule!

[RichieHindle]

Ha, then I'll tip my hat to Marc too, and fence it on to Ewen!