Replace manual Display impls with strum derive macros#55
Merged
gvonness-apolitical merged 2 commits intomainfrom Feb 10, 2026
Merged
Replace manual Display impls with strum derive macros#55gvonness-apolitical merged 2 commits intomainfrom
gvonness-apolitical merged 2 commits intomainfrom
Conversation
Eliminates boilerplate match-arm Display implementations across 22 files by using #[derive(strum::Display)] with serialize attributes. Keeps manual impls only for complex cases (conditional formatting, field interpolation, delegation to helper methods).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strum0.26 dependency withderivefeatureimpl Displayblocks across 22 files with#[derive(strum::Display)]and#[strum(serialize = "...")]attributesTest plan
cargo build --workspace --all-featurespassescargo test --workspace --all-featurespasses (853 tests, 0 failures)cargo clippy --workspace --all-features -- -D warningsclean