Extract shared crypto helpers from CLI encrypt/decrypt#57
Merged
gvonness-apolitical merged 1 commit intomainfrom Feb 10, 2026
Merged
Extract shared crypto helpers from CLI encrypt/decrypt#57gvonness-apolitical merged 1 commit intomainfrom
gvonness-apolitical merged 1 commit intomainfrom
Conversation
Move duplicated prompt_password, generate_salt, derive_key_argon2, and derive_key_pbkdf2 functions into a shared crypto_common module. Both encrypt.rs and decrypt.rs now call the shared helpers instead of maintaining their own copies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt_password,generate_salt,derive_key_argon2, andderive_key_pbkdf2functions fromencrypt.rsanddecrypt.rsinto a sharedcrypto_commonmodulememoryandparallelismparams directly instead of having two subtly different implementationsFollow-up to #56 (codebase cleanup).
Test plan
cargo build --workspace --all-featurespassescargo test --workspace --all-featurespasses (856 tests)cargo clippy --workspace --all-features -- -D warningsclean